Update headers for files copied from non ASF projects and update LICENSE #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
vvcephei and
collado-mike
as code owners
jbonofre
requested review from
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain,
ebyhr,
HonahX and
pingtimeout
as code owners
|
@justinmclean Can you please take a look, regarding your comment on Incubator general mailing list ? Thanks ! |
|
I will update spotless configuration to avoid to "force" ASF header (that's the reason why the header has been changed). |
dimas-b
reviewed
May 13, 2025
| @@ -37,7 +37,7 @@ if (!project.extra.has("duplicated-project-sources")) { | |||
| spotless { | |||
| kotlinGradle { | |||
| ktfmt().googleStyle() | |||
| licenseHeaderFile(rootProject.file("codestyle/copyright-header-java.txt"), "$") | |||
| // licenseHeaderFile(rootProject.file("codestyle/copyright-header-java.txt"), "$") | |||
There was a problem hiding this comment.
JB explained to me that this is to prevent spotlessApply from changing the headers back to ASF from dremio. We'll need to figure out how to get the plugin to allow for multiple headers.
There was a problem hiding this comment.
It's intentional: with that, spotless:apply "overwrites" all header with ASF header, which is wrong as we have to keep the original header in case of code copy.
There was a problem hiding this comment.
@jbonofre mind bringing this back?
There is targetExcludeIfContentContains/Regex
RussellSpitzer
approved these changes
May 14, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
May 22, 2025
* Fix header in the gradle-wrapper.properties (apache#1587) * Refactor GenericTableCatalog to support generic table federation (apache#1579) * initial commit * stable * javadocs * autolint * changes per review * Update headers for files copied from non ASF projects and update LICENSE (apache#1562) * [Policy Store] Enforce regex requirement for policy name (apache#1583) * Enforce regex requirement for policy name * enable validation in open api builder * FIx nit * Include LICENSE, NOTICE, DISCLAIMER files in the docker images (apache#1588) * main: Update swagger to v1.6.16 (apache#1594) * Eliminate usage of CatalogHandlers; introduce CatalogHandlerUtils (apache#1576) * compiles * wire it up * De-static, add config * autolint * license entry * cut over * pull * revert helm doc * autolint * Allow realm context resolution to execute blocking calls (apache#1591) * main: Update dependency com.adobe.testing:s3mock-testcontainers to v4.3.0 (apache#1597) * Fix header in helm chart (apache#1560) * Following vote/discussion on the Incubator general mailing list, NOTICE now contains part of Nessie NOTICE. (apache#1565) * In binary distributions, now we group the artifacts and we add BSD/MIT licenses inline (apache#1573) * Better null-safety for check against unsafe catalog configs (apache#1584) Better null-safety for check against unsafe catalog configs * Add support for federated principal and role with block for manual role assignment (apache#1353) * Add support for federated principal and role with block for manual role assignment * Update spec to distinguish federated and non-federated entities * Changed builder to allow setting federated status twice * Revert spec changes - add 'federated' property back to Principal entity * Fixed builder to remove federated property * Removed unnecessary openapi config flags * Fix compilation issue in test * Remove federated flag from principal entity * Fixed builder oversight * Fix compilation failures and rebase on main * Remove verbose terminal output for admin tool (apache#1598) * Site: Use the overview page as the home page (apache#1605) * Include only relevant information from Picocli NOTICE as it doesn't apply in Polaris (as we use binary package, not source package) (apache#1561) * Site: Simplified doc for spark download (apache#1608) * main: Update dependency software.amazon.awssdk:bom to v2.31.45 (apache#1607) * main: Update registry.access.redhat.com/ubi9/openjdk-21-runtime Docker tag to v1.22-1.1747241886 (apache#1603) * main: Update dependency boto3 to v1.38.18 (apache#1592) * merge fix --------- Co-authored-by: JB Onofré <[email protected]> Co-authored-by: Eric Maynard <[email protected]> Co-authored-by: Honah (Jonas) J. <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: Michael Collado <[email protected]> Co-authored-by: Yufei Gu <[email protected]> Co-authored-by: MonkeyCanCode <[email protected]>
adnanhemani
pushed a commit
to adnanhemani/polaris
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ASF header in the files copied from non ASF projects (but ASLv2 licensed).
It also updates
LICENSEwith files not actually copied (but created in Apache Polaris).